Skip to content

fix: show login screen when token expires during workspace polling #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Apr 11, 2025

  • in fact we will now jump to the login screen for any error other than socket timeout because of an OS wake-up
  • this patch also contains a re-work of the REST API exception. Coder backend sends very detailed messages with the reason for the http calls to be rejected. We now un-marshall those responses and fill the exception system with better details.

- in fact we will now jump to the login screen for any error other than socket timeout because of an OS wake-up
- this patch also contains a re-work of the REST API exception. Coder backend sends very detailed messages
  with the reason for the http calls to be rejected. We now un-marshall those responses and fill the exception
  system with better details.
@fioan89 fioan89 requested review from matifali and f0ssel April 11, 2025 20:33
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 11, 2025

image

- forcing the main screen to always show the same exception
- this patch refactors the code to accumulate the errors in a buffer and show them when auth screen is visible
- in addition, the error reporting uses the Snackbar api which provides greater control, and the possibility
  to stack errors one on top of each other. This approach simplifies the code on our side even more because
  the ui page no longer needs to accumulate the errors in a buffer and process them when a notifier is
  injected by toolbox.
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 11, 2025

With the second update:
image
image

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@fioan89 fioan89 merged commit db3ea7d into main Apr 14, 2025
5 checks passed
@fioan89 fioan89 deleted the fix-go-to-login-screen-when-token-is-expired branch April 14, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants